indygreg / python-build-standalone

Produce redistributable builds of Python
Mozilla Public License 2.0
1.97k stars 123 forks source link

Avoid incorrect triple match for substrings #250

Closed charliermarsh closed 5 months ago

charliermarsh commented 5 months ago

Summary

Given an artifact like cpython-3.8.19-x86_64-pc-windows-msvc-shared-pgo-20240401T1106.tar.gz, we were matching against the triple x86_64-pc-windows-msvc (rather than x86_64-pc-windows-msvc-shared); so the release code then assumed that the install suffix was shared-pgo rather than pgo, and failed to align the assets.

This should fix both of the issues described in #244, since the hard-float armv7 triples are also prefixes of the non-hard-float variants (armv7-unknown-linux-gnueabihf vs. armv7-unknown-linux-gnueabi).

Test Plan

Ran just release with these local changes (skipping uploads); verified that no missing-file errors were raised.