fix: detect preview versions of msvs

indygreg / python-build-standalone

Produce redistributable builds of Python

BSD 3-Clause "New" or "Revised" License

1.71k stars 107 forks source link

fix: detect preview versions of msvs #269

Open kfsone opened 3 weeks ago

kfsone commented 3 weeks ago

fixes #268

add the '-prerelease' flag to the vswhere subcommand,
give 'no vs found' error if the command returns empty string,
catch vswhere returning multiple installations,

zanieb commented 3 weeks ago

Thanks for contributing!

zanieb commented 3 weeks ago

Is there a compelling reason to support building with prerelease versions of Visual Studio?

kfsone commented 3 weeks ago

Is there a compelling reason to support building with prerelease versions of Visual Studio?

Ah - I can see why you might wonder that; "prerelease" recognizes the "Preview" aka canary editions. Which is not the same as whatever alpha or beta of 2024 or 2025 might eventually come into existence.

This is a fairly common pattern:

Stable + Firehose.