indykish / opendj-openam

Chef cookbook which stands up OpenDJ
Apache License 2.0
1 stars 1 forks source link

Redundant JRE package resource? #1

Closed danryu closed 11 years ago

danryu commented 11 years ago

At https://github.com/indykish/opendj-openam/blob/master/recipes/single_instance.rb#L13 you do an explicit install of JRE 7, using apt dependency management.

package "openjdk-7-jre" do
        action :install
end

But you have already declared a chef dependency on Java in metadata.rb:

%w{ java }.each do |cb|
  depends cb
end

Is this not clashing? Because you suggest with chef that you have a dependency on the "java" cookbook. But Java is fulfilled by installing a .deb package - not via Chef.

indykish commented 11 years ago

Dan, Good catch. The stuff pointed out by you in metadata.rb isn't needed. Yes our Devops team removed the content as suggested by you in metadata.rb and ran it today. It worked well. We'll post an updated copy in the chef community repo. on monday, since our team is taking off tomorrow. Thanks again for reporting it.

indykish commented 11 years ago

v 0.2 updated in http://community.opscode.com/cookbooks/opendj-openam with the fix. Thanks again.