search

indykoning / PyPi_GrowattServer

MIT License
80 stars 34 forks source link

Add randomly generated user agents #42

Closed muppet3000 closed 1 year ago

muppet3000 commented 1 year ago

Added an alternative solution to https://github.com/indykoning/PyPi_GrowattServer/pull/40

muppet3000 commented 1 year ago

Note - Once we agree on an implementation I'd like to update the documentation before it's merged, there's no point me doing that before the decision is made though

indykoning commented 1 year ago

It's looking good to me! We can still request without problems using this? 🙂

muppet3000 commented 1 year ago

It's looking good to me! We can still request without problems using this? 🙂

😄 Yeah it still works! I've emailed every possible support address I can find for Growatt asking them to collaborate with us, so I'm hoping they come back eventually!

muppet3000 commented 1 year ago

I've now added the documentation & an example with all the options and it even validates that it works.

I've changed the logic slightly so that it matches the way the server_url is stored, it also means that you can access the default value if you want to extend it and pass it back in (see my examples).

indykoning commented 1 year ago

Looks good! I'll merge this as 1.3.0 🎉