search

indykoning / PyPi_GrowattServer

MIT License
79 stars 34 forks source link

Added timeout for each requests #80

Open nagycsongor opened 8 months ago

nagycsongor commented 8 months ago

Requests without timeout goes into infinity wait which blocks forever the caller. Timeout helps for interrupting these calls and handling as an error.

indykoning commented 3 months ago

Sorry for the long wait, i like the idea! Do we want to set a default timeout, or rather keep it up to the user?

nagycsongor commented 3 months ago

@indykoning I do not know, I guess it ups on the user. In my case the problem was that in case of the server is not accessible stayed there forever and I could not exit from this wait on a normal way.

Rappelkiste98 commented 3 months ago

@nagycsongor can you also add the timeout to the new merged Noah Requests? I am at the holidays at the moment.

@indykoning I would say a default Timeout like 30 seconds, but the user can also configure a custom timeout. I think for 90% of the Users a default is fine like all the HomeAssistant Users that don't know that the integration is based on your project.