ineesalmeida / almeida-cv

Theme to build a customizeable printable CV with minor web responsiveness.
MIT License
190 stars 100 forks source link

Multilang content #15

Closed Melkor333 closed 3 years ago

Melkor333 commented 3 years ago

Hi

First of all, thanks a lot for making this simple to use and nice looking theme! :) The change in this PR allow users to have multilingual data, e.g. have data/en/content.yaml and data/de/content.yaml to be able to display the cv in multiple languages simultaneously.

I also updated the example to include a slightly "germanized" site (just so that the difference can be spotted). I assume your pronoun is "she" - I used that form for the german translation, i hope that's ok :). German is sadly quite gender biased and it's really hard to use work titles which don't refer to either he or she.

It's also implemented in a way that if there is no data/LANG/content.yaml it uses the default data/content.yaml file instead, which is why the english translation in the example is not in a folder data/en/content.yaml. That also means that this change shouldn't break existing sites. :partying_face:

Also the Photo: parameter needs to be referenced absolutely (with a / at the beginning), otherwise it won't work for sites accessed via baseURL/LANG.

b0ch3nski commented 3 years ago

Looks good to me :+1: