search

inejge / ldap3

A pure-Rust LDAP library using the Tokio stack
Apache License 2.0
220 stars 38 forks source link

Expose the nom dependency directly #102

Closed Firstyear closed 1 year ago

Firstyear commented 1 year ago

When using lber for the ldap3 server crate I maintain, we needed to have support for when an Incomplete error is returned. To achieve this we needed to manually add nom as a dependency of the same version as lber uses.

To help users of the lber crate it would be good to pub use nom::Err, or just pub use nom in the lber crate to prevent the need for them to "version match" nom + lber.

Thanks!

inejge commented 1 year ago

Hmm yes, it seems that Incomplete inadvertently went private during the port to nom 7. I prefer the minimal suggested fix (pub use nom::Err) so I'm going to use that. Thanks for the report.

Firstyear commented 1 year ago

Thanks :)