search

inejge / ldap3

A pure-Rust LDAP library using the Tokio stack
Apache License 2.0
220 stars 38 forks source link

Correct doc for UnrecognizedCriticalExtension #120

Closed chrisridd closed 7 months ago

chrisridd commented 7 months ago

Let me know if you'd like me to open an issue first.

There's a spelling mistake in the existing doc. But the main error is that UnrecognizedCriticalExtension is nothing to do with URLs, it is to do with controls.

inejge commented 7 months ago

Thanks for noticing the typo and submitting the PR! However, the error doesn't have to do anything with controls, see the (only) place where it's returned in src/result.rs, which parses the extended LDAP URL.

I'll push another commit which will fix the typo along with other doc fixes and close this PR.