inejge / ldap3

A pure-Rust LDAP library using the Tokio stack
Apache License 2.0
225 stars 39 forks source link

Windows compilation error: use of unstable library feature 'peek' #26

Closed jacobmorzinski closed 6 years ago

jacobmorzinski commented 6 years ago

Hi, On Windows, if I try to compile the examples from the README.md, I get a compilation error while building dependencies. For example, compiling the "Synchronous search" demo gives:

C:\...> cargo build
   ...
   Compiling mio v0.6.12
error: use of unstable library feature 'peek' (see issue #38980)
   --> C:\Users\Jacob\.cargo\registry\src\github.com-1ecc6299db9ec823\mio-0.6.12\src\sys\windows\tcp.rs:289:40
    |
289 |         match (&self.imp.inner.socket).peek(buf) {
    |                                        ^^^^
    |
    = help: add #![feature(peek)] to the crate attributes to enable

error: aborting due to previous error

error: Could not compile `mio`.

To learn more, run the command again with --verbose.

I'm unsure where to report this; would this be an issue with ldap3? tokio-core? mio?

For reference, I see that mio has a recent update to add TcpStream::peek #773, but their CI isn't flagging any problems.

jacobmorzinski commented 6 years ago

I now doubt whether I've captured enough details to reproduce the problem. When I test on a different computer, the other computer works just find and compiles mio v0.6.12 without problem, no compilation errors.

I'll re-check this on the original computer.

jacobmorzinski commented 6 years ago

My fault - I was accidentally using an older rustc (v1.19-nightly) . I've updated to v1.23-stable, and things work fine. Thanks for the library.