search

inejge / ldap3

A pure-Rust LDAP library using the Tokio stack
Apache License 2.0
226 stars 39 forks source link

add GitHub action for push and pr #39

Closed rizsotto closed 4 years ago

rizsotto commented 4 years ago

Adding continuous integration for this project. (Currently strict checking is disabled.)

rizsotto commented 4 years ago

Hey @inejge , is there a chance for you to look to this PR?

inejge commented 4 years ago

Hi, thanks for the PR and sorry for the delay. The crate has been ported to async/await and modernized code-wise; also formatted and passed through Clippy. So, it should a) compile without warnings, b) pass cargo fmt tests, c) pass Clippy tests. If you're still interested, could you update the PR to turn on all of those, and also limit Clippy to stable?

rizsotto commented 4 years ago

I've updated this PR as you suggested, but Clippy is still failing.

inejge commented 4 years ago

It's probably this issue, so I'm simply going to remove Clippy checking -- I do use Clippy, but can easily live with running it manually from time to time.