search

inejge / ldap3

A pure-Rust LDAP library using the Tokio stack
Apache License 2.0
220 stars 38 forks source link

Add Rustls support #43

Closed Geobert closed 4 years ago

Geobert commented 4 years ago

Now that the code has been updated to tokio 0.2 (thank you again for that!), it should be possible with not too much work to support rustls to add an alternative to native-tls.

inejge commented 4 years ago

Heh, not so fast :wink: Although rustls offers similar interfaces through its tokio adpater, they're not the same, and the point of the library is to work with as few special cases as possible. So, this can wait. I'll leave it open so it can be noticed.

Geobert commented 4 years ago

I'm so happy that this lib is back alive, sorry for my enthusiasm ;)

I'm opening this because we already use tokio-rustls because we want to avoid the native-tls. I've seen a PR to add rustls support to tiny-http (through rouille) and it was small. Hence why I though it's not a so big job to do. Sorry if I'm mistaken :)

Geobert commented 4 years ago

Hi @inejge,

do you mind if I have a look at that?

Regards,

inejge commented 4 years ago

I'm preparing to release 0.7 proper, and I'm not going to make potentially destabilizing changes to the code so close to the release. The first stable release is going to be 0.7.1; the earliest I can look into rustls support is after that. So, do work on it, but don't expect me to act on it immediately.

Geobert commented 4 years ago

Yes sure :) I started the work and put it behind a feature flag, so using native-tls will still be the same