search

inejge / ldap3

A pure-Rust LDAP library using the Tokio stack
Apache License 2.0
226 stars 39 forks source link

Support for Rustls #49

Closed Geobert closed 4 years ago

Geobert commented 4 years ago

fixes #43

I know you won't integrate it before stabilizing 0.7 but I make it available for review for whenever you can :)

PR done on behalf of Isode Ltd

inejge commented 4 years ago

Thanks for the PR! I gave it a brief look and noticed just one issue: the changes wouldn't allow compiling the crate with no TLS support. I've left the comments in the code. When testing, try compiling with --no-default-features.

Geobert commented 4 years ago

Thanks for the merge! I though it would not be included before 0.7.1? Nice surprise :D

inejge commented 4 years ago

Okay, I updated this a bit (native-tls can be chosen by specifying tls as the feature name, like before) and merged, since I'll publish another alpha because of other changes -- see #48, you'll be pleasantly surprised, I hope 🙂