Closed hjanos1 closed 5 months ago
Seeing as NODE_ENV
would usually either be development
or production
: would it make sense to pass production
if the app()->environment
is production, or pass development
otherwise? That avoids it being set to 'local' for example which wouldn't be a useful value in most cases, but is common in Laravel.
Heya. We removed our master branch. Feel free to re-attempt this to 1.x!
Got an error like the one below, so I have realized that
process.env.NODE_ENV === 'production'
checks always detect that the environment is not production on the SSR node server, sometimes leading to debug mode behaviour and skipping of production optimizations.This PR solves the issue by passing through Laravel's environment to the Node-based Inertia SSR server when starting the server through the
inertia:start-ssr
command.Error mentioned: