search

inertiajs / inertia-laravel

The Laravel adapter for Inertia.js.
https://inertiajs.com
MIT License
2.03k stars 227 forks source link

[1.x] remove IDE helpers from package #654

Open krzysztofrewak opened 3 weeks ago

krzysztofrewak commented 3 weeks ago

Since v1.1.0 release (with changes from #625) my IDE has a big problem with understanding where Illuminate\Http\Request is implemented.

image image

It looks like [_ide_helpers.php](https://github.com/inertiajs/inertia-laravel/blob/1.x/_ide_helpers.php) is propagating its own classes into projects using Inertia.

I believe that IDE helpers could be great if someone needs them, but they should be in scope of package only. They should not interfere with projects using these packages.

This should fix the problem.

SamMakesCode commented 1 week ago

Yeah, having issues with this too. This feels like a developer preference and shouldn't be included in the repository or it's scope should be limited.