bknoles
commented
3 years ago Intermittent issues are the best! 😄
We haven't seen anything like this before, but there definitely could be something unexpected happening in the middleware.
Since InertiaRails is last on the middleware list, any of the middlewares above it might alter the status code. Would you be able to debug inside the gem within your project so we can verify if this is an InertiaRails problem?
I'd want to see if the status is a 303 after this line runs, during the sign out request that fails as you described.
https://github.com/inertiajs/inertia-rails/blob/master/lib/inertia_rails/middleware.rb#L18
something like:
def call(env)
@env = env
status, headers, body = @app.call(env)
# ... bunch of skipped code here
status = 303 if inertia_non_post_redirect?(status)
# Cool kids will probably use an actual debugger
puts "HEY THERE THE STATUS IS: #{status}"
return stale_inertia_get? ? force_refresh(request) : [status, headers, body]
end
christoomey
reinvanimschoot
caifara
I recently ran into an issue where the "Sign Out" button of my app would occasionally result in an inertia modal w/ 404 error page.
I opened this as https://github.com/inertiajs/inertia/issues/419 on the main Inertia repo, but they kindly helped me dig a bit deeper and I've now confirmed that the issue is that response status code.
At this point I'm guessing the issue is somewhere in my app / middleware stack, but I wanted to share here in case you folks have any thoughts as to how this might be happening.
I'm specifically running into this with the "Sign Out" button in my app. The problem flow is.
I've found this tricky to reproduce as most cases send the correct 303 status code, but I have been able to reproduce it.
For reference, here's my middleware stack.
Rack middleware stack
``` use Rack::Cors use Honeybadger::Rack::UserInformer use Honeybadger::Rack::UserFeedback use Honeybadger::Rack::ErrorNotifier use Rack::Rewrite use ActionDispatch::SSL use Rack::Sendfile use ActionDispatch::Static use Rack::Deflater use ActionDispatch::Executor use ActiveSupport::Cache::Strategy::LocalCache::Middleware use RailsAutoscaleAgent::Middleware use Rack::Runtime use Rack::MethodOverride use ActionDispatch::RequestId use Rack::Timeout use RequestStore::Middleware use ActionDispatch::RemoteIp use Rails::Rack::Logger use ActionDispatch::ShowExceptions use ActionDispatch::DebugExceptions use Rollbar::Middleware::Rails::RollbarMiddleware use ActionDispatch::Callbacks use ActionDispatch::Cookies use ActionDispatch::Session::CookieStore use ActionDispatch::Flash use ActionDispatch::ContentSecurityPolicy::Middleware use Rack::Head use Rack::ConditionalGet use Rack::ETag use Rack::TempfileReaper use Clearance::RackSession use Warden::Manager use Coverband::BackgroundMiddleware use Rack::Attack use ScoutApm::Middleware use InertiaRails::Middleware run MyApp::Application.routes ```Any thoughts? (I'll also certainly understand if you want to close this under the assumption that the problem is on my side, but figured it was worth an ask).