Fix types for npm packages

inertiajs / inertia

Inertia.js lets you quickly build modern single-page React, Vue and Svelte apps using classic server-side routing and controllers.

https://inertiajs.com

MIT License

6.3k stars 423 forks source link

Fix types for npm packages #1794

Closed irshadahmad21 closed 5 months ago

irshadahmad21 commented 7 months ago

Fixes #1793 #1770

This PR:

Changes the build tool from ESBuild to Tsup
Ensures that correct types are produced on build
Fixes the exports in package.json for all the TS packages

Using the arethetypeswrong CLI, here are the before and after results

BEFORE	AFTER
`@inertiajs/core`

`@inertiajs/react`

`@inertiajs/vue2`

`@inertiajs/vue3`

Next steps

Update typescript and @types/react* to the latest version
Get rid of a few // @ts-expect-error comments

irshadahmad21 commented 7 months ago

It's getting difficult to work with Inertia with broken types. Lots of TS errors and broken auto-completions on modern TS stack.

Can we please have a look at this and ship it as soon as we can?

CC: @reinink @claudiodekker @jessarcher

irshadahmad21 commented 7 months ago

Had to rebase to resolve conflicts in lockfile

irshadahmad21 commented 6 months ago

@reinink @claudiodekker @jessarcher

Is there any possibility of this landing anytime soon?

If not, then is it fine to create a fork and publish to npm to temporarily solve the problem for our team(s)?

jrson83 commented 5 months ago

@irshadahmad21 could you please contact me on the inertia discord jrson83 or by mail just@jrson.me.

irshadahmad21 commented 5 months ago

For keeping this hanging for 2 months and from Inertia Discord discussions, it seems like the issue is not even acknowledged and this tooling update is rather considered a "major rewrite" which is "highly unlikely" to land. Thus we are no longer interested in this.

reinink commented 5 months ago

@irshadahmad21 Hey definitely not trying to ignore, we've actually been busy lately trying to get on top of issues (thanks a bunch to @driesvints for all his help here), and we've actually talked about this PR internally. This project has a lot of moving parts and so we need to be careful when making changes, plus I work on this project in my free time, so things often take months, not weeks or days. Honestly doing my best 😕

I also don't know much about tsup, but I am familiar with ESBuild, so making this change required me to do some homework first before changing a key part of our tooling.