search

inertiajs / pingcrm

A demo application to illustrate how Inertia.js works.
http://demo.inertiajs.com
MIT License
2.1k stars 767 forks source link

fix for php8 #111

Closed sietzekeuning closed 3 years ago

sietzekeuning commented 3 years ago

To make the CRM work with php8 you need laravel/ui 3.2 and league/glide 1.7.

reinink commented 3 years ago

Have you tested this to make sure the image endpoint actually works? I thought the Glide 2.x branch had a different API (because I wrote it a long time ago 🤣).

ed-mor commented 3 years ago

tomorrow I'm going to test with php 8

sietzekeuning commented 3 years ago

Ah you are right, this endpoint doesn't work. Will check later to fix either the endpoint, or to update your 2.x branch to php8 to get them to work together nicely.

reinink commented 3 years ago

I have fixed both these issues.

  1. I removed laravel/ui (#138).
  2. I switched to Glide version 1.x (463f622d0a07836950014d6c5eb3da5dc93d9836).

Thanks for your help here either way!