Fix $assert must be of type Inertia\Testing\Assert

inertiajs / pingcrm

A demo application to illustrate how Inertia.js works.

http://demo.inertiajs.com

MIT License

2.1k stars 767 forks source link

Fix $assert must be of type Inertia\Testing\Assert #170

Closed SamuelMwangiW closed 6 months ago

SamuelMwangiW commented 2 years ago

Fix Argument #1 ($assert) must be of type Inertia\Testing\Assert, Inertia\Testing\AssertableInertia given error in tests

SamuelMwangiW commented 2 years ago

It would be much better to make it in this way: use Inertia\Testing\AssertableInertia as Assert

Thanks @Leotrimlota for your review. I have update the class to a alias instead. I personally would have preferred the Class name in full but I agree to be wrong.

SamuelMwangiW commented 6 months ago

I bet it is safe to assume the PR won't be reviewed.

Closing as abandoned