search

inertiajs / pingcrm

A demo application to illustrate how Inertia.js works.
http://demo.inertiajs.com
MIT License
2.1k stars 767 forks source link

I updated from webpack to vite and Laravel from 8 to 10 #206

Closed leandroximenes closed 5 months ago

leandroximenes commented 9 months ago

I've updated the project, transitioning from Webpack to Vite. Additionally, I've upgraded the Laravel version from 8 to 10, ensuring compatibility with the latest features and improvements. These changes aim to optimize the project's development environment with the current version.

I made all these modifications in the devContainer because it's my preferred environment, and I have already committed the changes. I temporarily removed files like ESLint and Prettier just to simplify the process for now, but we can reintroduce them later after configuring in the devContainer.

My next steps involve upgrading the tests and implementing debugging with devContainer.

I'm thrilled to contribute to the project.

ordago commented 9 months ago

It seems there are other additional extraneous modifications. Chiefly, prettier and eslint are removed in the PR.

leandroximenes commented 9 months ago

Thanks for your feedback! I'll address the mentioned libraries and remove built assets from commits. I temporarily removed Prettier and ESLint to avoid confusion but will reintegrate them in the next commit. Your insights are valuable, and I appreciate your review.

leandroximenes commented 9 months ago

Hello @ordago,

I would like to inform you that I have completed the required corrections, and the revised version is now ready for your review

ordago commented 9 months ago

I would like to inform you that I have completed the required corrections, and the revised version is now ready for your review

Hey @leandroximenes

I'm sorry if I gave the impression that I'm a maintainer of the repo, I'm not. I just follow the repo and provided feedback. I wish you luck with the PR.

leandroximenes commented 9 months ago

Thank you, @ordago

I appreciate your feedback, and I'm learning from it. I believe that this way, I can contribute a consistent and relevant (PR). Although you are not the maintainer, I appreciate your time spent with me.

jessarcher commented 5 months ago

Thanks! Ended up letting Shift handle this in #209.