search

ines / termynal

⬛️ Lightweight and modern terminal animations using async/await
MIT License
1.7k stars 110 forks source link

Dynamically load lines feature #6

Closed patmigliaccio closed 5 years ago

patmigliaccio commented 6 years ago

Added the ability to dynamically load line elements (fixes #4) by passing an array of objects into the lineData property of the options object into the constructor of Termynal class.

I've tried to maintain as much consistency with the existing codebase as possible, including an example and updated README. One step that would still need to be completed is updating the minification of termynal.min.js; unsure of what tool is being used for minification, I wanted to leave that up to the creator/maintainer to keep it consistent.

Also, adding a package.json and pushing this to npm would be super. I'm a huge fan of this project and it'd be great to make it more accessible to developers.

Saw-mon-and-Natalie commented 6 years ago

@patmigliaccio, In #3 @ines mentions that the minified version is compiled with Babel. (ref)

patmigliaccio commented 6 years ago

@Saw-mon-and-Natalie, nice find! But, I was hoping there would be a bit more detail like a .babelrc file to work with?