search

inet-framework / simulte

SimuLTE - LTE System Level Simulation Model and Simulator for INET & OMNeT++ - deprecated, use Simu5G instead
https://simulte.omnetpp.org
Other
136 stars 109 forks source link

Possible error in UE Feedback generation #15

Open legion47T opened 7 years ago

legion47T commented 7 years ago

The sendFeedback method in UE's physical layer has the lines 514 and 515:

fbPkt->setLteFeedbackDoubleVectorDl(fbDl);
fbPkt->setLteFeedbackDoubleVectorDl(fbUl);

https://github.com/inet-framework/simulte/blob/master/src/stack/phy/layer/LtePhyUe.cc#L515

I don't claim to fully understand the feedback generation yet so I might be mistaken, but shouldn't the UL vector be filled with the fbUL info instead of the DL vector being reset? Like this:

fbPkt->setLteFeedbackDoubleVectorDl(fbDl);
fbPkt->setLteFeedbackDoubleVectorUl(fbUl);

At least during a swift debugger check, setLteFeedbackDoubleVectorUl() was exclusively called by the eNodeB.