search

inetum-orleans / docker-devbox-ddb

Erase environment differences, make developers happy !
https://inetum-orleans.github.io/docker-devbox-ddb
MIT License
4 stars 1 forks source link

`docker.ip` on windows should default to 127.0.0.1 #216

Closed Toilal closed 2 years ago

Toilal commented 2 years ago

Docker desktop + WSL2 is now the defacto standard for docker on windows, so docker.ip configuration on windows should default to 127.0.0.1, instead of raising this error

ddb.feature.feature.FeatureConfigurationAutoConfigureError: Feature "docker" has invalid configuration.
  ip: auto-configuration has failed (Invalid network interface: docker0). Please configure docker.ip manually.
lcube45 commented 2 years ago

Do you really need Docker desktop with WSL2 ? Vanilla WSL2 seems good enough. Or maybe Rancher Desktop for a more friendly licence usage ?

Toilal commented 2 years ago

It don't think the underlying docker engine will impact ddb that much, any distro should work when running ddb binary from developer's machine. ddb relies on docker and docker-compose binaries, so if those binaries are working properly from shell, it should also work through ddb.

Toilal commented 2 years ago

I try to make ddb work properly on windows environment for now, and Docker desktop is my testing environment though.

lcube45 commented 2 years ago

I was just wondering why this sudden love for a another layer like docker desktop instead of a vanilla wsl2 with docker/docker compose. No worry with docker desktop except licensing :)