inex / IXP-Manager

Full stack web application powering peering at over 200 Internet Exchange Points (IXPs) globally.
https://www.ixpmanager.org/
GNU General Public License v2.0
377 stars 161 forks source link

using AS-NULL in customer as-macro #228

Closed nickhilliard closed 9 years ago

nickhilliard commented 9 years ago

If AS-NULL is used as the entry for a customer's as-macro, then the following warning is generated from ixptool.php -a irrdb-cli.update-asn-db:

2015-07-29T16:42:52+01:00 ALERT (1): IRRDB CLI action - removing invalid ASN from IRRDB result set!

This happens because IrrdbCliController\validateASNs() ends up with $asns containing a blank entry. This function could be patched to ignore this, but it would be better for IXP_BGPQ3\getAsnList() to ensure that it's not generating poop in the first place.

As a longer term thing, it would be nice if bgpq3 supported json for as-list output.

nickhilliard commented 9 years ago

https://github.com/snar/bgpq3 supports json output as of https://github.com/snar/bgpq3/commit/61c23c53b32d1d8187473e8b59bbd9985a3168bf

I'll open this as a separate ticket.

nickhilliard commented 9 years ago

fixed in fbb8f74