search

inex / IXP-Manager

Full stack web application powering peering at over 200 Internet Exchange Points (IXPs) globally.
https://www.ixpmanager.org/
GNU General Public License v2.0
377 stars 161 forks source link

"IP Addresses" vs. "IPv4/6 Addresses" IXP admin action #458

Closed kieber closed 6 years ago

kieber commented 6 years ago
ISSUE TYPE

Bug Report

OS

Linux 4.4.0-116-generic #140-Ubuntu SMP Mon Feb 12 21:23:04 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

VERSION

Both

define( 'APPLICATION_VERSION', '4.7.3' ); define( 'APPLICATION_VERDATE', '2018021900' );

and

define( 'APPLICATION_VERSION', '4.8.0' ); define( 'APPLICATION_VERDATE', '201807030000' );

ENVIRONMENT

kieber@ixp01:/srv/ixpmanager$ php -v PHP 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 (cli) (built: May 2 2018 12:43:14) ( NTS ) Copyright (c) 1997-2017 The PHP Group Zend Engine v3.0.0, Copyright (c) 1998-2017 Zend Technologies with Zend OPcache v7.0.30-1+ubuntu16.04.1+deb.sury.org+1, Copyright (c) 1999-2017, by Zend Technologies kieber@ixp01:/srv/ixpmanager$ dpkg -l | grep php
ii libapache2-mod-php7.0 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 server-side, HTML-embedded scripting language (Apache 2 module) ii php-common 1:60+ubuntu16.04.1+deb.sury.org+1 all Common files for PHP packages ii php-ds 1.2.5-1+ubuntu16.04.1+deb.sury.org+1 amd64 PHP extension providing efficient data structures for PHP 7 ii php-gettext 1.0.11-2+deb.sury.org~xenial+1 all read gettext MO files directly, without requiring anything other than PHP ii php-igbinary 2.0.6~rc1-1+ubuntu16.04.1+deb.sury.org+1 amd64 igbinary PHP serializer ii php-memcache 3.0.9~20160311.4991c2f-7+ubuntu16.04.1+deb.sury.org+1 amd64 memcache extension module for PHP ii php-memcached 3.0.4+2.2.0-1+ubuntu16.04.1+deb.sury.org+1 amd64 memcached extension module for PHP, uses libmemcached ii php-msgpack 2.0.2+0.5.7-3+ubuntu16.04.1+deb.sury.org+1 amd64 PHP extension for interfacing with MessagePack ii php-pear 1:1.10.5+submodules+notgz-1+ubuntu16.04.1+deb.sury.org+1 all PEAR Base System ii php-rrd 2.0.1+1.1.3-4+ubuntu16.04.1+deb.sury.org+1 amd64 PHP bindings to rrd tool system ii php7.0 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 all server-side, HTML-embedded scripting language (metapackage) ii php7.0-bcmath 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 Bcmath module for PHP ii php7.0-cgi 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 server-side, HTML-embedded scripting language (CGI binary) ii php7.0-cli 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 command-line interpreter for the PHP scripting language ii php7.0-common 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 documentation, examples and common module for PHP ii php7.0-curl 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 CURL module for PHP ii php7.0-fpm 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 server-side, HTML-embedded scripting language (FPM-CGI binary) ii php7.0-gd 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 GD module for PHP ii php7.0-intl 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 Internationalisation module for PHP ii php7.0-json 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 JSON module for PHP ii php7.0-mbstring 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 MBSTRING module for PHP ii php7.0-mcrypt 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 libmcrypt module for PHP ii php7.0-mysql 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 MySQL module for PHP ii php7.0-opcache 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 Zend OpCache module for PHP ii php7.0-readline 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 readline module for PHP ii php7.0-snmp 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 SNMP module for PHP ii php7.0-xml 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 DOM, SimpleXML, WDDX, XML, and XSL module for PHP ii php7.0-zip 7.0.30-1+ubuntu16.04.1+deb.sury.org+1 amd64 Zip module for PHP kieber@ixp01:/srv/ixpmanager$

CONFIGURATION

kieber@ixp01:/srv/ixpmanager$ cat .env | egrep -v '(^#|^\s*$|^DB_|^APPKEY|^HELPDESK|^IDENTITY|^MAIL|^IXP_API_RIR_PASSWORD|^IXP_API_PEERINGDB)' APP_DEBUG=true APP_URL="https://www.bcix.de/ixp" APP_TIMEZONE="Europe/Berlin" APP_LOG="single" IXP_API_JSONEXPORTSCHEMA_PUBLIC=true IXP_MULTIIXP_ENABLED=false IXP_RESELLER_ENABLED=true IXP_AS112_UI_ACTIVE=false GRAPHER_BACKENDS="mrtg|sflow" GRAPHER_BACKEND_MRTG_WORKDIR="/srv/mrtg" GRAPHER_BACKEND_MRTG_LOGDIR="/srv/mrtg" GRAPHER_BACKEND_SFLOW_ENABLED=true GRAPHER_BACKEND_SFLOW_ROOT="http://194.29.229.44/grapher-sflow/" GRAPHER_CACHE_ENABLED=false VIEW_SKIN="bcix" VIEW_SMARTY_SKIN="bcix" AUTH_ZF1_PWHASH="bcrypt" CACHE_DRIVER=memcached SESSION_LIFETIME=1200 SESSION_DRIVER=file DOCTRINE_PROXY_AUTOGENERATE=true DOCTRINE_CACHE=memcached DOCTRINE_CACHE_NAMESPACE=IXPMANAGERNAMESPACE IXP_IRRDB_BGPQ3_PATH=/usr/bin/bgpq3 kieber@ixp01:/srv/ixpmanager$

SUMMARY

Logging in I see on the left hand menu "IXP Admin Actions" and among those "IP Addresses". I can click "IP Addresses", and everything works fine. When I click "Switches" (just above "IP Addresses") the menue item "IP Addresses" changes to "IPv4/6 Addresses". Clicking "IPv4/6 Addresses" yields an error page. Clicking any other menue item restores the correct "IP Addresses" menue item.

I have found the offending string in files application/views/menu.phtml and var/templates_c/910d913903ff36e1b4053f8a0159661869d6b5b5_0.file.menu.phtml.php

STEPS TO REPRODUCE

see above

EXPECTED RESULTS

I don't expect pressing "Switches" to mangle the "IP Addresses" menue item. :)

ACTUAL RESULTS

error page

IMPORTANCE
barryo commented 6 years ago

Thanks @kieber

This is a hangover from the backend framework migration. I'll let @yannrobin confirm but I'd say this is already fixed in a queued development branch waiting on my review 😢

yannrobin commented 6 years ago

I confirm that this bug has been fixed and is waiting to be pushed.