search

inex / IXP-Manager

Full stack web application powering peering at over 200 Internet Exchange Points (IXPs) globally.
https://www.ixpmanager.org/
GNU General Public License v2.0
377 stars 161 forks source link

update-l2database.pl doesn’t work with --vlanid #717

Closed alarig closed 3 years ago

alarig commented 3 years ago
ISSUE TYPE

Bug Report

OS

Description: Ubuntu 20.04.2 LTS

VERSION
root@manager:/srv/ixpmanager# git status
HEAD detached at v5.8.0
ENVIRONMENT
root@manager:/srv/ixpmanager# php -v
PHP 7.4.3 (cli) (built: Jul  5 2021 15:13:35) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.3, Copyright (c), by Zend Technologies
root@manager:/srv/ixpmanager# dpkg -l '*php*'
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                               Version                        Architecture Description
+++-==================================-==============================-============-================================>
un  libapache2-mod-php                 <none>                         <none>       (no description available)
un  libapache2-mod-php7.2              <none>                         <none>       (no description available)
un  libapache2-mod-php7.3              <none>                         <none>       (no description available)
ii  libapache2-mod-php7.4              7.4.3-4ubuntu2.5               amd64        server-side, HTML-embedded scrip>
un  php                                <none>                         <none>       (no description available)
un  php-amqp                           <none>                         <none>       (no description available)
un  php-apcu                           <none>                         <none>       (no description available)
un  php-apcu-bc                        <none>                         <none>       (no description available)
un  php-ast                            <none>                         <none>       (no description available)
un  php-bcmath                         <none>                         <none>       (no description available)
un  php-calendar                       <none>                         <none>       (no description available)
un  php-cgi                            <none>                         <none>       (no description available)
un  php-cli                            <none>                         <none>       (no description available)
ii  php-common                         2:75                           all          Common files for PHP packages
ii  php-composer-ca-bundle             1.2.6-1                        all          utility library to find a path t>
ii  php-composer-semver                1.5.1-1                        all          utilities, version constraint pa>
ii  php-composer-spdx-licenses         1.5.3-1                        all          SPDX licenses list and validatio>
ii  php-composer-xdebug-handler        1.4.0-1                        all          Restarts a process without Xdebug
un  php-crypt-gpg                      <none>                         <none>       (no description available)
un  php-ctype                          <none>                         <none>       (no description available)
un  php-curl                           <none>                         <none>       (no description available)
un  php-dom                            <none>                         <none>       (no description available)
ii  php-ds                             1.2.9-2build1                  amd64        PHP extension providing efficien>
un  php-exif                           <none>                         <none>       (no description available)
un  php-ffi                            <none>                         <none>       (no description available)
un  php-fileinfo                       <none>                         <none>       (no description available)
un  php-ftp                            <none>                         <none>       (no description available)
un  php-gd                             <none>                         <none>       (no description available)
un  php-geoip                          <none>                         <none>       (no description available)
un  php-gmagick                        <none>                         <none>       (no description available)
un  php-iconv                          <none>                         <none>       (no description available)
ii  php-igbinary                       3.1.2+2.0.8-1build1            amd64        igbinary PHP serializer
un  php-imagick                        <none>                         <none>       (no description available)
un  php-intl                           <none>                         <none>       (no description available)
un  php-json                           <none>                         <none>       (no description available)
ii  php-json-schema                    5.2.9-1                        all          implementation of JSON schema
un  php-mbstring                       <none>                         <none>       (no description available)
ii  php-memcache                       3.0.9~20170802.e702b5f-4build1 amd64        memcache extension module for PHP
ii  php-memcached                      3.1.4+2.2.0-1                  amd64        memcached extension module for P>
un  php-mongodb                        <none>                         <none>       (no description available)
ii  php-msgpack                        2.1.0beta1-0ubuntu2            amd64        PHP extension for interfacing wi>
un  php-mysqli                         <none>                         <none>       (no description available)
un  php-mysqlnd                        <none>                         <none>       (no description available)
un  php-opcache                        <none>                         <none>       (no description available)
un  php-pdo                            <none>                         <none>       (no description available)
un  php-pdo-mysql                      <none>                         <none>       (no description available)
un  php-pear                           <none>                         <none>       (no description available)
un  php-phar                           <none>                         <none>       (no description available)
un  php-posix                          <none>                         <none>       (no description available)
ii  php-psr-container                  1.0.0-2                        all          Common Container Interface (PHP >
ii  php-psr-log                        1.1.2-1                        all          common interface for logging lib>
un  php-psr-log-implementation         <none>                         <none>       (no description available)
un  php-radius                         <none>                         <none>       (no description available)
un  php-readline                       <none>                         <none>       (no description available)
un  php-redis                          <none>                         <none>       (no description available)
ii  php-rrd                            2.0.1+1.1.3-7build1            amd64        PHP bindings to rrd tool system
un  php-shmop                          <none>                         <none>       (no description available)
un  php-simplexml                      <none>                         <none>       (no description available)
un  php-smbclient                      <none>                         <none>       (no description available)
un  php-snmp                           <none>                         <none>       (no description available)
un  php-sockets                        <none>                         <none>       (no description available)
un  php-ssh2                           <none>                         <none>       (no description available)
ii  php-symfony-console                4.3.8+dfsg-1ubuntu1            all          run tasks from the command line
un  php-symfony-contracts              <none>                         <none>       (no description available)
un  php-symfony-dependency-injection   <none>                         <none>       (no description available)
un  php-symfony-event-dispatcher       <none>                         <none>       (no description available)
ii  php-symfony-filesystem             4.3.8+dfsg-1ubuntu1            all          basic filesystem utilities
ii  php-symfony-finder                 4.3.8+dfsg-1ubuntu1            all          find files and directories
un  php-symfony-lock                   <none>                         <none>       (no description available)
ii  php-symfony-process                4.3.8+dfsg-1ubuntu1            all          execute commands in sub-processes
ii  php-symfony-service-contracts      1.1.8-1                        all          Generic abstractions related to >
un  php-symfony-service-implementation <none>                         <none>       (no description available)
un  php-sysvmsg                        <none>                         <none>       (no description available)
un  php-sysvsem                        <none>                         <none>       (no description available)
un  php-sysvshm                        <none>                         <none>       (no description available)
un  php-tokenizer                      <none>                         <none>       (no description available)
un  php-uploadprogress                 <none>                         <none>       (no description available)
un  php-uuid                           <none>                         <none>       (no description available)
un  php-xdebug                         <none>                         <none>       (no description available)
un  php-xml                            <none>                         <none>       (no description available)
un  php-xmlreader                      <none>                         <none>       (no description available)
un  php-xmlwriter                      <none>                         <none>       (no description available)
un  php-xsl                            <none>                         <none>       (no description available)
ii  php-yaml                           2.0.4+1.3.2-2build1            amd64        YAML-1.1 parser and emitter for >
un  php-zip                            <none>                         <none>       (no description available)
un  php-zmq                            <none>                         <none>       (no description available)
un  php5.6-common                      <none>                         <none>       (no description available)
un  php5.6-json                        <none>                         <none>       (no description available)
un  php7.0-common                      <none>                         <none>       (no description available)
un  php7.0-curl                        <none>                         <none>       (no description available)
un  php7.2-sodium                      <none>                         <none>       (no description available)
ii  php7.4                             7.4.3-4ubuntu2.5               all          server-side, HTML-embedded scrip>
ii  php7.4-bcmath                      7.4.3-4ubuntu2.5               amd64        Bcmath module for PHP
un  php7.4-calendar                    <none>                         <none>       (no description available)
ii  php7.4-cgi                         7.4.3-4ubuntu2.5               amd64        server-side, HTML-embedded scrip>
ii  php7.4-cli                         7.4.3-4ubuntu2.5               amd64        command-line interpreter for the>
ii  php7.4-common                      7.4.3-4ubuntu2.5               amd64        documentation, examples and comm>
un  php7.4-ctype                       <none>                         <none>       (no description available)
ii  php7.4-curl                        7.4.3-4ubuntu2.5               amd64        CURL module for PHP
un  php7.4-dom                         <none>                         <none>       (no description available)
un  php7.4-ds                          <none>                         <none>       (no description available)
un  php7.4-exif                        <none>                         <none>       (no description available)
un  php7.4-ffi                         <none>                         <none>       (no description available)
un  php7.4-fileinfo                    <none>                         <none>       (no description available)
un  php7.4-fpm                         <none>                         <none>       (no description available)
un  php7.4-ftp                         <none>                         <none>       (no description available)
ii  php7.4-gd                          7.4.3-4ubuntu2.5               amd64        GD module for PHP
un  php7.4-gettext                     <none>                         <none>       (no description available)
un  php7.4-iconv                       <none>                         <none>       (no description available)
un  php7.4-igbinary                    <none>                         <none>       (no description available)
ii  php7.4-intl                        7.4.3-4ubuntu2.5               amd64        Internationalisation module for >
ii  php7.4-json                        7.4.3-4ubuntu2.5               amd64        JSON module for PHP
ii  php7.4-mbstring                    7.4.3-4ubuntu2.5               amd64        MBSTRING module for PHP
un  php7.4-memcache                    <none>                         <none>       (no description available)
un  php7.4-memcached                   <none>                         <none>       (no description available)
un  php7.4-msgpack                     <none>                         <none>       (no description available)
ii  php7.4-mysql                       7.4.3-4ubuntu2.5               amd64        MySQL module for PHP
un  php7.4-mysqli                      <none>                         <none>       (no description available)
un  php7.4-mysqlnd                     <none>                         <none>       (no description available)
ii  php7.4-opcache                     7.4.3-4ubuntu2.5               amd64        Zend OpCache module for PHP
un  php7.4-pdo                         <none>                         <none>       (no description available)
un  php7.4-pdo-mysql                   <none>                         <none>       (no description available)
un  php7.4-phar                        <none>                         <none>       (no description available)
un  php7.4-posix                       <none>                         <none>       (no description available)
ii  php7.4-readline                    7.4.3-4ubuntu2.5               amd64        readline module for PHP
un  php7.4-rrd                         <none>                         <none>       (no description available)
un  php7.4-shmop                       <none>                         <none>       (no description available)
un  php7.4-simplexml                   <none>                         <none>       (no description available)
ii  php7.4-snmp                        7.4.3-4ubuntu2.5               amd64        SNMP module for PHP
un  php7.4-sockets                     <none>                         <none>       (no description available)
un  php7.4-sysvmsg                     <none>                         <none>       (no description available)
un  php7.4-sysvsem                     <none>                         <none>       (no description available)
un  php7.4-sysvshm                     <none>                         <none>       (no description available)
un  php7.4-tokenizer                   <none>                         <none>       (no description available)
ii  php7.4-xml                         7.4.3-4ubuntu2.5               amd64        DOM, SimpleXML, XML, and XSL mod>
un  php7.4-xmlreader                   <none>                         <none>       (no description available)
un  php7.4-xmlwriter                   <none>                         <none>       (no description available)
un  php7.4-xsl                         <none>                         <none>       (no description available)
un  php7.4-yaml                        <none>                         <none>       (no description available)
ii  php7.4-zip                         7.4.3-4ubuntu2.5               amd64        Zip module for PHP
un  phpapi-20190902                    <none>                         <none>       (no description available)
un  phpgacl                            <none>                         <none>       (no description available)
root@manager:/srv/ixpmanager#
CONFIGURATION
root@manager:/srv/ixpmanager# egrep -v '(^#|^\s*$|^DB_|^APP_KEY|^HELPDESK|^IDENTITY|^MAIL_|^IXP_API_RIR_PASSWORD|^IXP_API_PEERING_DB_)' .env
APP_DEBUG=false
APP_URL="https://manager.breizh-ix.net/"
APP_TIMEZONE="UTC"
APP_LOG="single"
IXP_RESELLER_ENABLED=true
IXP_AS112_UI_ACTIVE=false
IXP_FE_FRONTEND_DISABLED_LOGO=false
GRAPHER_BACKENDS="mrtg|sflow|smokeping"
GRAPHER_CACHE_ENABLED=true
GRAPHER_BACKEND_MRTG_DBTYPE="rrd"
GRAPHER_BACKEND_MRTG_WORKDIR="/var/lib/mrtg"
GRAPHER_BACKEND_MRTG_LOGDIR="http://mrtg.adm.breizh-ix.net/mrtg"
IXP_API_JSONEXPORTSCHEMA_PUBLIC=true
CACHE_DRIVER=memcached
DOCTRINE_PROXY_AUTOGENERATE=false
DOCTRINE_CACHE=memcached
DOCTRINE_CACHE_NAMESPACE=IXPMANAGERNAMESPACE
IXP_IRRDB_BGPQ3_PATH=/usr/bin/bgpq3
root@manager:/srv/ixpmanager#
SUMMARY

If I run update-l2database.pl with --vlanid, the script exits with code 1.

STEPS TO REPRODUCE
root@manager:/srv/ixpmanager# which update-l2database.pl
/usr/local/bin/update-l2database.pl
root@manager:/srv/ixpmanager# ls -lh /usr/local/bin/update-l2database.pl
lrwxrwxrwx 1 root root 61 Jul  8 14:42 /usr/local/bin/update-l2database.pl -> /srv/ixpmanager/tools/runtime/l2database/update-l2database.pl
root@manager:/srv/ixpmanager# update-l2database.pl --vlanid 10
ERROR: invalid vlanid specified.
root@manager:/srv/ixpmanager# echo $?
1
root@manager:/srv/ixpmanager#
EXPECTED RESULTS

The DB being populated

ACTUAL RESULTS

Exit code 1

IMPORTANCE

I can’t set sflow up

RELEVANT LOGS
nickhilliard commented 3 years ago

the VLAN ID is the database ID, not the dot1q tag. You can get the DB ID from the first column in.

https://manager.breizh-ix.net/vlan/list