inex / IXP-Manager

Full stack web application powering peering at over 200 Internet Exchange Points (IXPs) globally.
https://www.ixpmanager.org/
GNU General Public License v2.0
363 stars 159 forks source link

[BF] bird2: Remove stray whitespace when no MD5 #852

Open rlaager opened 1 year ago

rlaager commented 1 year ago

[BF] bird2: Remove stray whitespace when no MD5

When no MD5 password is set, there should not be extra whitespace.

This is a minor thing right now, but its something that intersects with other changes I made for BFD.

Please verify the output before merging. This works on my system, but I have another line added after it in my skin. Also, I do not run a route collector, so the change there has not been tested.

In addition to the above, I have:

rlaager commented 1 year ago

BTW, even if you don't care about BFD upstream, I would still appreciate if this change could be merged, as it makes it easier for me to skin in BFD.

barryo commented 1 year ago

@rlaager - yes, I'll look at merging this. We're super sensitive about anything that touches router configuration and especially route server configuration as those are production critical services.

This means generally that merges have to be covered by the test database and by the sample known good configs; and that they have to apply cleanly without interrupting BGP sessions.

At a glance, the no-md5 use case is either not covered by the configs / test cases and so I'll need to add that in.