search

inex / IXP-Manager

Full stack web application powering peering at over 200 Internet Exchange Points (IXPs) globally.
https://www.ixpmanager.org/
GNU General Public License v2.0
363 stars 159 forks source link

Missing check for 32bit routeserver asn? #870

Closed jbemmel closed 11 months ago

jbemmel commented 11 months ago

Just wondering - I noticed https://github.com/inex/IXP-Manager/blob/b5d596c9d4a7038396afe014b7b9a66c4e791741/resources/views/api/v4/router/server/bird/community-filter.foil.php#L55

while https://github.com/inex/IXP-Manager/blob/b5d596c9d4a7038396afe014b7b9a66c4e791741/resources/views/api/v4/router/server/bird2/community-filter.foil.php#L73 uses

 # it's unwise to conduct a 32-bit check on a 16-bit value
    if routeserverasn > 65535 || peerasn > 65535 then
            return true;

Shouldn't the first one do the same?

jbemmel commented 11 months ago

Actually, https://github.com/inex/IXP-Manager/issues/842 so I guess this is a moot point