search

inex / birdseye

A Simple Secure Micro Service for Querying Bird (JSON API)
MIT License
46 stars 21 forks source link

Changes to date parsing in Routes.php #4

Closed aduitsis closed 7 years ago

aduitsis commented 7 years ago

As discussed over email, here is a small patch to handle extended date strings. Went a little overboard with the DateTime::createFromFormat modifications, hope those changes are acceptable. If not, please reject with a trifle of feedback so that I will know what to adjust.

barryo commented 7 years ago

Hi @aduitsis - I'll have a look at this today / soon. I may edit the regex's a little.

Can you confirm that you submit this under the existing MIT license?

aduitsis commented 7 years ago

Hello @barryo, yes, same license as the original software.

aduitsis commented 7 years ago

I suspect you might want to put \s+ instead of literal ' '-space or try to work out a more explicit pattern to get the date. Obviously no problem in any case.

barryo commented 7 years ago

Thanks @aduitsis - merged into master.

Let me know if it works for you and I'll stamp it as v1.0.5 and release.

aduitsis commented 7 years ago

Date parsing is okay afaict.

If you are going to make a release, could you please include a tarball like in 1.0.3 so that there won't be a need to issue composer update, etc?

barryo commented 7 years ago

Done: https://github.com/inex/birdseye/releases/tag/v1.0.5

aduitsis commented 7 years ago

Thank you very much!