search

inexorabletash / jslogo

Logo in JavaScript
https://calormen.com/jslogo
Other
368 stars 146 forks source link

Hebrew translation fixes #119

Closed noamtamim closed 4 years ago

noamtamim commented 4 years ago
inexorabletash commented 4 years ago

Thank you!

noamtamim commented 4 years ago

I've been asked to teach basic LOGO to preschoolers (in Israel, in Hebrew) - making sure everything is ready :-)

noamtamim commented 4 years ago

BTW, I created a POC (using GHP) of showing only the very basic commands in the sidebar. I modified language.html for that. You might want to take a look: https://noamtamim.com/jslogo/. Basically my gh-pages branch is Hebrew oriented. I've also modified the code that starts CodeMirror to set its direction to RTL, according to this: https://codemirror.net/demo/bidi.html. I didn't know where to take this value from, so in my branch it's fixed at "rtl".

inexorabletash commented 4 years ago

document.body.dir gets set to "rtl" if specified in the localization file. If you look in index.html there's a "localizationComplete" handler that checks data.page - you could try adding code to configure CodeMirror there. That'd be a great change to add if you can get it working.

Like most English speakers I am bad at RTL/BiDi conventions for text display and editing, so your guidance here would be very helpful to get it right.

On Mon, Dec 9, 2019 at 11:41 PM Noam Tamim notifications@github.com wrote:

BTW, I created a POC (using GHP) of showing only the very basic commands in the sidebar. I modified language.html for that. You might want to take a look: https://noamtamim.com/jslogo/. Basically my gh-pages branch is Hebrew oriented. I've also modified the code that starts CodeMirror to set its direction to RTL, according to this: https://codemirror.net/demo/bidi.html. I didn't know where to take this value from, so in my branch it's fixed at "rtl".

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/inexorabletash/jslogo/pull/119?email_source=notifications&email_token=AAF4LWYBYRADTQBEU3F5AF3QX5BZJA5CNFSM4JVHKZG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGOIXDI#issuecomment-563907469, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF4LW5KVIQVTYKA26HLSGDQX5BZJANCNFSM4JVHKZGQ .