inexorabletash
commented
10 months ago Yeah, I'm going to need you to submit separate PRs for the changes. You do this by having a separate branch for each "topic" or intended change, and submit a PR for each.
High level comments though:
-
Please don't add the "min" files or the workspace files
-
The CodeMirror change should be generalized in some way to not hard-code the terms; it should be reworked to use the localization files.
-
Splitting the CSS out of the language file should be done as a stand-alone change with no additions, so it's easier to understand what the changes are (e.g. adding the background image?)
-
Reformatting the language.html file, e.g. adding additional HTML tags, should be avoided, especially if unrelated to the change. Close tags are not needed for DT and DD, and replacing multiple DTs with BR changes the semantics of the doc.
-
Please don't add comments into the JSON files
-
It's not obvious how language-fr.html file would be used - there's probably a subtle change somewhere I'm not spotting.
-
It looks like the index.js change is a bug fix?
Hello, Really sorry, this is my first Pull request and I figured out my commits are badly done (I should commit one change after another and not this way). Already sent you an Email about that... Here the changes made on the several files:
<html></html>,<head></head>,<body></body>,</dt>,</dd>), Provided more anchors to summary. Externalize CSS (ref.css and ref.min.css) and improving styling (turtle.png, more space between blocks,...)This translation should be reviewed by french users. I translated arbitrary using this rules:
répète(translation ofrepeat)becomesrepete.Thanks in advance for your patience. Joël