search

inexorabletash / polyfill

JavaScript Polyfills, Shims and More
Other
1.36k stars 354 forks source link

Errors in IE 8 #113

Closed bflatmajor closed 7 years ago

bflatmajor commented 7 years ago

"Symbol is null, not defined or not a function" at polyfill.min.js: 1, 15232.

"Document is not defined" at polyfill.js: 5116.

inexorabletash commented 7 years ago

b59adb55369b022d1bb0009367e524b1aa2dc42a should take care of the "Document is not defined". I'll have to poke at the Symbol issue a bit more - does it occur in the non-minimized script?

bflatmajor commented 7 years ago

No.

And I print t after t.Symbol=n in polyfill.min.js (same as global.Symbol = Symbol in polyfill.js), the result seems to be function raw, which is object window in other browsers. Does that mean something is wrong with global object after compression?

My English sucks, did I make it clear?

inexorabletash commented 7 years ago

Sounds like a minifier bug. I'll update to the latest.

On Dec 21, 2016, at 6:04 PM, Boring notifications@github.com wrote:

No.

And I print t after t.Symbol=n in polyfill.min.js (same as global.Symbol = Symbol in polyfill.js), the result seems to be function raw, which is object window in other browsers.

My English sucks, did I make it clear?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

inexorabletash commented 7 years ago

Hrm, latest version of uglify (2.7.5) did not fix the problem. Need to dig deeper.

inexorabletash commented 7 years ago

I think this was fixed in 0959c790d179856d028c9bacb8f0488b26568f02 - I added --support-ie8 to the options passed to Uglify (the minifier). This seems to have resolved issues when testing w/ IE11 in IE8 mode.

@boringer - Can you please verify?

bflatmajor commented 7 years ago

Works well now. Thank you.