search

inexorabletash / polyfill

JavaScript Polyfills, Shims and More
Other
1.36k stars 354 forks source link

Detect URL implementations that don't support search setter #143

Closed JakeChampion closed 4 years ago

JakeChampion commented 6 years ago

It looks like Safari 10.1 has an issue with the URL search setter. I've patched the feature detection in the polyfill to ensure that the polyfill is applied if URL implementations have a buggy search setter. Here is a screenshot of the tests running on Safari 10.1: Screenshot of Safari 10.1 running the url tests and having a test failure

Here is a screenshot of the tests running on Safari 10.1 after the feature detect was patched: Screenshot of Safari 10.1 running the url test and having all the tests passing

JakeChampion commented 5 years ago

@inexorabletash, would you be able to review this at all? If you are busy with other projects and want some help maintaining this project, I'd be happy to help out as I use it quite a lot for https://polyfill.io

inexorabletash commented 5 years ago

Sorry for the delay - definitely busy with other projects and not actively maintaining this; I appreciate the reviews by others.

There's also #151- if folks can agree on something that at least passes the same tests as now (and hopefully adds/passes more) I'll merge it.

inexorabletash commented 5 years ago

@JakeChampion - transferring ownership of this project is a possibility; I'm not even using it any more (I've gone for a subset).