Hey there! Thanks for starting to learn GitHub. You've created a PR but this just represents dropping new files into the root of the repo. The intention is that since you're submitting updates to existing data that you provide the changes to the file(s) directly. Please look at some other PRs for inspiration.
The data file you would be modifying is res/Sectors/M1105/Heakhafaw.sec although you're going further and proposing replacing the SEC file with T5 file. To make reviews easier it would might be better to do a sequence of commits, one that converts the existing SEC data to T5, then a second commit that updates the T5 file.
The metadata file would be new (res/Sectors/M1105/Heakhafaw.xml), but will require changes to res/Sectors/M1105/M1105.xml circa line 2154 to the minimum (location, names, and a DataFile and MetadataFile reference). Note that when you're modifying the data file format (from SEC to a T5 format) the DataFile needs a Type="SecondSurvey" attribute added.
Also, please look at surrounding files to ensure that the content is appropriate. For example:
The data file doesn't have the comments at the start. Those are generated by the site's API as a convenience, but aren't part of the data.
The metadata file doesn't have DataFile elements (those exist only in the M1105.xml index file)
T5SS allegiance codes aren't included in the metadata file; those are defined globally in res/t5ss/allegiance_codes.tab
Hey there! Thanks for starting to learn GitHub. You've created a PR but this just represents dropping new files into the root of the repo. The intention is that since you're submitting updates to existing data that you provide the changes to the file(s) directly. Please look at some other PRs for inspiration.
The data file you would be modifying is
res/Sectors/M1105/Heakhafaw.sec
although you're going further and proposing replacing the SEC file with T5 file. To make reviews easier it would might be better to do a sequence of commits, one that converts the existing SEC data to T5, then a second commit that updates the T5 file.The metadata file would be new (
res/Sectors/M1105/Heakhafaw.xml
), but will require changes tores/Sectors/M1105/M1105.xml
circa line 2154 to the minimum (location, names, and aDataFile
andMetadataFile
reference). Note that when you're modifying the data file format (from SEC to a T5 format) theDataFile
needs aType="SecondSurvey"
attribute added.Also, please look at surrounding files to ensure that the content is appropriate. For example:
DataFile
elements (those exist only in theM1105.xml
index file)res/t5ss/allegiance_codes.tab
I know this seems like a lot but much of that is because you've done too much extra work that I'd just throw away. Take a look at past PRs (https://github.com/inexorabletash/travellermap/pulls?q=is%3Apr+is%3Aclosed) to get a feeling for what a good PR looks like.