search

inexorabletash / travellermap

The source code to TravellerMap.com
https://travellermap.com
Other
118 stars 53 forks source link

Reverted nine D worlds in Lishun 1105 and aligned trade remarks with Jim Kundert #424

Closed bobbyjim closed 1 month ago

bobbyjim commented 1 month ago

Jim Kundert and I dug into Lishun data to find out exactly why about 1% of the UWPs changed from "D" atmospheres (in Sunbane data) to "A" and a couple "B" atmospheres in the Travellermap 1105 dataset. We traced the work back to my work fixing Sunbane to jibe with AOTI and Traveller5.

The problem is that the data was generated for MegaTraveller originally, which classified "D" atmospheres as Fluid water. This rule was dropped for T5, and as far as we know didn't exist in other rulesets.

So when I fixed Lishun data, instead of just removing the Fl code, I downgraded the atmospheres of ~9 worlds. Fl was a MegaTraveller side-effect of the atmosphere code... not the other 'way 'round.

I have reverted those changes and dropped the Fl codes for those worlds instead. This is a closer fit to the original data and does no harm to AOTI.

bobbyjim commented 1 month ago

Note that I've updated the /t5ss/data file, but also the /Sectors/1105 data is also changed. I figure that's not hurting anything.

inexorabletash commented 1 month ago

Note that I've updated the /t5ss/data file, but also the /Sectors/1105 data is also changed. I figure that's not hurting anything.

Yeah that's fine unless they get out of sync. But I reran the tool res/t5ss/update_world_data.pl --source-data and it didn't generate a diff so it's all good.