search

inexorgame-obsolete / deprecated-cube-engine-inexor

UNMAINTAINED: Please have a look at the vulkan-renderer
https://inexor.org
zlib License
11 stars 1 forks source link

Update folders to equivalate 095e275 #356

Closed Fohlen closed 7 years ago

Fohlen commented 7 years ago

Following PR brings back the Node.js support as it used to be before "the big" Anyhow we will have to rethink about Node.js packaging since it relies on the .proto file and that one in turn is in the build folder using conan..

Croydon commented 7 years ago

Following PR brings back the Node.js support as it used to be before "the big"

The big what?

Fohlen commented 7 years ago

The big PR with about 1000 files changed .. @a-teammate splitted it up and merged the C++ side respectively.

a-teammate commented 7 years ago

The .proto file gets installed in ./bin/ for all archs and os, so this is no problem.

I think the more pressing question we have now with this PR is: How can we keep the code repo clean of binary blobs? There are several images commited and I think this will pretty rapidly increase the repo size. Can we put them somewhere in the media repos? or can we put the whole node folder to media? Or should we make it a submodule?

aschaeffer commented 7 years ago

:+1: for separate nodejs stuff from c++ stuff --> #360

Because Inexor Flex will start Inexor Kernel in future, we should reverse the submodule: Inexor Flex has a submodule Inexor Kernel.

a-teammate commented 7 years ago

So is this one obsolete?

Fohlen commented 7 years ago

I think so

aschaeffer commented 7 years ago

Yes