inexorgame-obsolete / deprecated-cube-engine-inexor

UNMAINTAINED: Please have a look at the vulkan-renderer
https://inexor.org
zlib License
11 stars 1 forks source link

WIP: snapcraft #373

Closed Fohlen closed 7 years ago

Fohlen commented 7 years ago

The following PR add's a WIP snappy package for Inexor. It is WIP because there's still some issues with the paths which I am hopefully able to resolve soon. Despites, I did wanted to dig into the launchpad pipeline .. our snappy packages are there too!

Fohlen commented 7 years ago

@Croydon this could as well be builded by our Jenkins CI, see here https://snapcraft.io/docs/build-snaps/ci-integration

Fohlen commented 7 years ago

Once the bash script is adjusted we could as well change the package grade and add this to the snapcraft store.

Fohlen commented 7 years ago

The current snapcraft.yaml is struggeling with https://bugs.launchpad.net/ubuntu/+source/snapcraft/+bug/1576282 and https://bugs.launchpad.net/snapcraft/+bug/1594809

Croydon commented 7 years ago

@Fohlen I'm still struggeling with depedencies in our CI, when I'm done with that I want to look into the upload of Conan packages to conan.io (I expect a dramatically reduce in build time) and then I might look into building snap in our CI if you want.

Could we make snap a subdirectory of tool or something? I don't like it that we continue to add many directories in root.

Fohlen commented 7 years ago

@Croydon I did remove the folder.

Croydon commented 7 years ago

Oops. Sorry 😊

come-maiz commented 7 years ago

@Fohlen it would be useful if you comment on those bugs affecting you, with an explanation of your use case.

Fohlen commented 7 years ago

@elopio the issue is actually being caused because python is used in a scriptlet. That in turn falls back to system python, and all the "wooble" apparently caused issues with imports.

come-maiz commented 7 years ago

Interesting. I wonder if you could use something like $PYTHONPATH=$SNAPCRAFT_STAGE/... in the scriptlet.

Fohlen commented 7 years ago

Will be closed in favor of https://github.com/inexor-game/code/wiki/Release-and-build-strategy Packages are: