search

inexorgame-obsolete / deprecated-cube-engine-inexor

UNMAINTAINED: Please have a look at the vulkan-renderer
https://inexor.org
zlib License
11 stars 1 forks source link

Resolving issue #389 #391

Closed fallinbryan closed 7 years ago

fallinbryan commented 7 years ago

Every Header now has #pragma once, including the ones that had no include guards previously.

I am not sure how to squash all commits into one however.

a-teammate commented 7 years ago

Hey Bryan, Its already merged in #390 :)

fallinbryan commented 7 years ago

What about the header files that had no include guards at all?

a-teammate commented 7 years ago

Yeah i only did what i mentioned in the other PR: I did a simple find&replace for your comment and replaced them with include guards.

I just realized that ive "stolen" your PR maybe a bit, as you would have been able to learn to squash commits.. I'll try to open some more refactoring issues, which should be resolvable similarly.

How has your experience been building Inexor? Did it work? My suggestion is for squashing commits and anything git-related: Smartgit (you can do anything like that in the GUI)

a-teammate commented 7 years ago

Ah i see i missed some..

fallinbryan commented 7 years ago

Yeah, there was just a few that I didn't 'git' commented. (apologies for the pun). No worries about "stolen PR," I think it super cool I was able to contribute at all, as this was my first taste of social programming.

I have not yet had to opportunity to try to build, finals week and all, but I hope to soon.

I have been using the github desktop app, I will try Smartgit though.

IceflowRE commented 7 years ago

Take a look at Gitkraken too.