inexorgame-obsolete / deprecated-cube-engine-inexor

UNMAINTAINED: Please have a look at the vulkan-renderer
https://inexor.org
zlib License
11 stars 1 forks source link

Refactor server/client + shrink monster headers #455

Closed a-teammate closed 6 years ago

a-teammate commented 7 years ago

what we do with this PR:

320 (refactor the gameserver code) is in reach (could be done in this PR, but no need imo)

and even #170 is pretty near.

Is it working?

Its working for e.g. ffa or teamplay, but some other modes are not fully working yet.
The following bugs are to solve:

afterwards we could

severity?

This does touch a lot of code. probably best to merge it as soon as the issues are resolved.

How to test?

build and install as usual (see wiki). afterwards npm start in the flex directory (to start the client) afterwards/or before that click the server.bat (or the server script for unix) ingame write /connect into the console. thats it.

aschaeffer commented 7 years ago

I'll review it soon.

a-teammate commented 7 years ago

If you find more bugs than the listed ones: would be great to hear :)

a-teammate commented 6 years ago

@Croydon i reverted that change. I will squash these two commits ("do x" and "revert do x") as soon the ci ran through one time. @aschaeffer plz review EDIT: I squashed em

GitCop commented 6 years ago

There were the following issues with your Pull Request

Guidelines are available at https://github.com/inexorgame/inexor-core/wiki/Git-FAQ#how-should-i-format-my-git-commit-message


This message was auto-generated by https://gitcop.com

a-teammate commented 6 years ago

I think i found the source of the remaining gamemode issues @aschaeffer (return instead of break.. err)

Also i reverted any change regarding the maxfps (so the gamespeed should be normal again when using maxfps)

-> Mergeable!

aschaeffer commented 6 years ago

I'll try it today or tomorrow