Closed a-teammate closed 6 years ago
I'll review it soon.
If you find more bugs than the listed ones: would be great to hear :)
@Croydon i reverted that change. I will squash these two commits ("do x" and "revert do x") as soon the ci ran through one time. @aschaeffer plz review EDIT: I squashed em
There were the following issues with your Pull Request
Guidelines are available at https://github.com/inexorgame/inexor-core/wiki/Git-FAQ#how-should-i-format-my-git-commit-message
This message was auto-generated by https://gitcop.com
I think i found the source of the remaining gamemode issues @aschaeffer (return instead of break.. err)
Also i reverted any change regarding the maxfps (so the gamespeed should be normal again when using maxfps)
-> Mergeable!
I'll try it today or tomorrow
what we do with this PR:
320 (refactor the gameserver code) is in reach (could be done in this PR, but no need imo)
and even #170 is pretty near.
Is it working?
Its working for e.g. ffa or teamplay, but some other modes are not fully working yet.
The following bugs are to solve:
test the demo mode(on the hackathon)fix the userinfo about the players being wrongly placed(deferred, probably caused somewhen else)afterwards we could
severity?
This does touch a lot of code. probably best to merge it as soon as the issues are resolved.
How to test?
build and install as usual (see wiki). afterwards
npm start
in the flex directory (to start the client) afterwards/or before that click the server.bat (or the server script for unix) ingame write/connect
into the console. thats it.