inexor-flex depends on node-gyp needs python as an end-user dependency

inexorgame-obsolete / deprecated-cube-engine-inexor

UNMAINTAINED: Please have a look at the vulkan-renderer

https://inexor.org

zlib License

11 stars 1 forks source link

inexor-flex depends on node-gyp needs python as an end-user dependency #456

Closed Fohlen closed 6 years ago

Fohlen commented 6 years ago

Title says it all. Since python 2.7 is shipped by default on almost every linux and OSX that's not too bad. For windows, that could do it:

https://github.com/felixrieseberg/windows-build-tools

Fohlen commented 6 years ago

this is also related to #269 @terencode I will test wether the above module works, and if so, we can add it to the install instructions for Windows

Fohlen commented 6 years ago

will be solved by #277

Croydon commented 6 years ago

Is there no way we can get rid of Python as an end-user dep?

Fohlen commented 6 years ago

Unless you want to build gyp, a c++ compiler, cmake and python as virtual packages: no.

Croydon commented 6 years ago

Could you please explain the dep tree? Why do we need node-gyp, therefore gyp..?

Fohlen commented 6 years ago

grpc, segfault handler build via node-gyp, build via gyp. gyp is on top of python gyp also requires a compiler-toolset (what you would call build-essential on Debian)

a-teammate commented 6 years ago

node-gyp is used by two dependencies (one which is essential: grpc and one which is really useful: segfault-handler) which are build in c++ rather than js but have node.js bindings. node-gyp is a meta-build tool comparable to CMake but written in python and deprecated (its underlying technology was created by google: GYP). It's also not python 3.x compatible.

The suggested tool looks pretty good. You are probably right @Fohlen to let the installer (#277) install the windows-build-tools globally first (it's not becoming apparent though how to use this module to build npm install cleanly afterwards, or is it?

Fohlen commented 6 years ago

@a-teammate and I agreed to fork segfault-handler and pre-compile it via node-pre-gyp That way

we squash bugs in the segfault lib
get rid of Python as an end dependency

Croydon commented 6 years ago

FYI: We are not the only ones annoyed by the situation

https://github.com/nodejs/NG/issues/24 https://github.com/cmake-js/cmake-js https://github.com/nodejs/node-gyp/issues/960

Fohlen commented 6 years ago

This issue will be resolved by #465 indefinitely

a-teammate commented 6 years ago

Since we removed the node-segfault-handler temporarily, we can close this. As we finished #465 we can enable the handling of segfault errors in native node modules again.