inexorgame-obsolete / deprecated-cube-engine-inexor

UNMAINTAINED: Please have a look at the vulkan-renderer
https://inexor.org
zlib License
11 stars 1 forks source link

Fork off node-segfault-handler #465

Closed Fohlen closed 5 years ago

Fohlen commented 6 years ago

Fork off node-segfault-handler and package with node-pre-gyp to work around #456

To-Do:

Fohlen commented 6 years ago

@Croydon said he would like to do the Docker/Travis fiddling

I will attach the summary from Riot here,

Consider the naming scheme from https://github.com/mapbox/node-pre-gyp#package_name to upload binaries

Croydon commented 6 years ago

Add a matrix for multiple node versions and distros (Trusty), (optional)

@Fohlen Is the binary Node.js and OS version specific?

Fohlen commented 6 years ago

@Croydon unfortanly yes. For Ubuntu 12 and 14 it might not matter because of (for older dists) GCC4 / GCC5 (for newer dists). Anyhow compiling the dependencies needs to be done at least for every different Node.js version since extensions are NODE_ABI dependant

a-teammate commented 6 years ago

Although the segfault-handler is very useful in the case of errors we can leave it out for 0.9. I will still provide my fixes and am hoping that @Croydon could upload the binaries for 0.10.

Croydon commented 6 years ago

I will soon make time to work on this (just to make that clear).

But I'm also pretty sure that this decision will hunt us in the future. Do we really want to maintain it permanentely, can we maintain it permanentely and is there really no alternative?

We are not the only ones who want to invest Node.js app crashes, what are all these projects doing?

Croydon commented 6 years ago

I set up Docker containers with Ubuntu Xenial with Node.js 6 (LTS) and Node.js 8. It compiles successfully. https://travis-ci.org/inexorgame/node-segfault-handler/builds/283043535

@Fohlen Are you already familiar with node-pre-gyp and how to use it?

Croydon commented 6 years ago

@a-teammate Where can I find your fixes?

Croydon commented 6 years ago

On a second look it's rather insane to fork this off and maintaince it by ourselves. We should look for other solutions.

a-teammate commented 6 years ago

This is very true..

Croydon commented 5 years ago

There is a decision to move away from Node, therefore we don't need node-segfault-handler anymore and even if, we should definitely not maintain our own node segfault handler.