inexorgame-obsolete / deprecated-cube-engine-inexor

UNMAINTAINED: Please have a look at the vulkan-renderer
https://inexor.org
zlib License
11 stars 1 forks source link

#109 Restyle Comments fix #466

Closed bobbybrot closed 6 years ago

bobbybrot commented 6 years ago

Fixed numerous warnings encountered when using Doxygen to document code. Added new comments for easier code readability of some functions.

Note: There are still a few warnings that needs to be corrected by someone more familiar with the project's code. I have attached a file with the last warnings that needs correcting and where they can be found.

I hope you find my edits acceptable. Documentation.leftover.txt

Fohlen commented 6 years ago

Hello there @bobbybrot and thank you for your contribution, it's very much appreciated! We will look over this in the next couple days, suggest likewise improvements and fix the mentioned left over warnings.

bobbybrot commented 6 years ago

Sure thing, I shall keep an eye out. :)

bobbybrot commented 6 years ago

As a question, what will happen with the leftover functions that need documenting?

Croydon commented 6 years ago

I would suggest to fill a follow up issue and merge this pull request now. Since it will go first intos @a-teammate's branch he needs to decide.

bobbybrot commented 6 years ago

Alright thanks for letting me know. I will wait it out and see what happens.

bobbybrot commented 6 years ago

(Sorry wrong button :D)

a-teammate commented 6 years ago

contents of documentation.leftover.txt:

yo

void tick() gets executed every frame (we have a main loop). this function is actually virtual meaning any class deriving from this class, will actually want to implement this function (which then gets executed every frame)

unistd.h is for unix only. try https://stackoverflow.com/a/22445280

dunno about the rest atm :D try to add the documentation or if not possible reformat the info in the doc comment to silence the warning :)

bobbybrot commented 6 years ago

There we go, that should bring us closer to closing issue #109

a-teammate commented 6 years ago

Very nice! Thank you, I will put this into server_standalone as soon as I can resume working on it (currently in holidays)

This will make it into 0.9 definitely :)

a-teammate commented 6 years ago

merged with remove_standalone2 in 3760f2dc25efe0e88aa79ab36539e7c61a155649 ! :) As i can finally resume working on remove_standalone2, it will come into master soon