inexorgame-obsolete / deprecated-cube-engine-inexor

UNMAINTAINED: Please have a look at the vulkan-renderer
https://inexor.org
zlib License
11 stars 1 forks source link

cross platform way to upgrade node.js and npm #470

Closed a-teammate closed 5 years ago

a-teammate commented 6 years ago

As time shifts we will need to upgrade node.js and npm as @Croydon already mentioned.
So when striving for an automatic upgrading of inexor ( #37 ) we need to handle the case that flex requires a newer version of nodejs.

packages which might help:

Edit: The problem is: imagine we need a newer version of nodejs for a newer version of flex. how would we upgrade node? we upgrade inexor-flex in the npm prestart section. Now the new inexor-flex requires a new nodejs version. how do we upgrade?

Croydon commented 6 years ago

Before we speak about upgrading we should speak about installing them I guess :)

aschaeffer commented 6 years ago

Upgrading node.js and npm doesn't have any prio atm. The requirements for node.js and npm are set and won't change soon. I would suggest to remove it from milestone 0.9.0-alpha

Fohlen commented 6 years ago

@a-teammate just giving you a quick reminder about #452 where we agreed not to extend the release without prior agreement/discussion any more. Removing the milestone.

a-teammate commented 6 years ago

Actually this is not a new issue, this is just a part of #37 we already agreed on. Nvm it's okay if that's not for 0.9 @Croydon true. we should speak about both in this issue, since in this case it's pretty much the same (upgrading and installing from scratch) as it requires the same tools. (Then we just let the from-scratch-installer wrap the method we choose here)

Fohlen commented 6 years ago

I've been thinking about this issue again. I think that, when we will install the LTS version of node.js it will be sufficient and serve an up-to-date, compatible version of node for at least 2 years. This is not a pressing issue. We can also think about using flex to initiate an update script (which the user will have to agree to). There are plenty of options.

a-teammate commented 6 years ago

on windows i found out its very easy: just download the node installer and run it again. in passive mode, the user does not even need to interact :)

a-teammate commented 6 years ago

Note: After upgrading nodejs the native modules grpc and nodegit need to be upgraded! npm rebuild nodegit grpc --update-binary

Croydon commented 6 years ago

on windows i found out its very easy: just download the node installer and run it again. in passive mode, the user does not even need to interact :)

This could mess up the configuration if the user already has a different Node.js installed and we just either overwrite or install a second version, right? At least if we add it to the path. Are we doing that?

a-teammate commented 6 years ago

What kind of configuration? The silent installer is not for devs, it's for players. Devs will have the option to skip an upgrade. Otherwise this is the recommended kind to upgrade nodejs on windows: rerun the installer

ghost commented 6 years ago

Greetings! I've noticed that game installer removes older nodejs version and replace it with v8.3 (at this particular moment) and found that very irritating since I need to work with v6. Please, consider local nodejs installation as workaround for this as I'm sure that updating environment of the user (at least silently) can be considered as a bad attitude.

a-teammate commented 6 years ago

Yeah sorry for that! At this very moment working on a better solution :)

a-teammate commented 6 years ago

its fixed with the newly uploaded installer :)

Croydon commented 5 years ago

Closing as the decision was made to move away from Node.js