inexorgame-obsolete / deprecated-cube-engine-inexor

UNMAINTAINED: Please have a look at the vulkan-renderer
https://inexor.org
zlib License
11 stars 1 forks source link

conan-CEF errors if whitespace in username #485

Closed a-teammate closed 7 years ago

a-teammate commented 7 years ago

Either this https://github.com/inexorgame/conan-CEF/blob/stable/3.2704.1424.gc3f0a5b/conanfile.py#L69 need to become args = ['-DCEF_ROOT="{}"'.format(self.get_cef_distribution_name())] or that https://github.com/inexorgame/conan-CEF/blob/stable/3.2704.1424.gc3f0a5b/conanfile.py#L73 needs to become self.run('cmake "{}" {} {}'.format(self.conanfile_directory, cmake.command_line, " ".join(args)))

If we do both, the error probably goes away which appears if you try to conan install CEF/3.2704.1424.gc3f0a5b@inexorgame/testing with a user name with spaces (or somehow similar when building in a folder with spaces)

what to do?

Croydon commented 7 years ago

https://github.com/inexorgame/conan-CEF/commit/d7e4076799c3fdb26dd1ce9a1543d94c46dcc665

a-teammate commented 7 years ago

(the second line was the problem: no " around self.conan_directory. attention: could be an undiscovered issue for other conanfiles as well.)