search

inexorgame-obsolete / deprecated-cube-engine-inexor

UNMAINTAINED: Please have a look at the vulkan-renderer
https://inexor.org
zlib License
11 stars 1 forks source link

nodegit can't get compiled with Python 3 #492

Closed Croydon closed 5 years ago

Croydon commented 6 years ago

Check if we can do this?

Fohlen commented 6 years ago

Is this certain? :octocat:

Croydon commented 6 years ago

nodegit requires gyp, which doesn't support Python 3, so this is a problem for all Node.js versions which doesn't have binaries for easy download.

This will become better when nodegit adopts n-api. Till then I will try to make a pull request for each new major Node.js version to the nodegit repo to keep their CI building up-to-date.

Croydon commented 6 years ago

Python 2 will be soon deprecated and end of life 2020. So Node.js definitely needs to move sooner or later or add Python 3 support.

Croydon commented 5 years ago

Closing this in favour of #609.

Also we can't do much here anyway when we stay with nodegit.