inexorgame-obsolete / deprecated-cube-engine-inexor

UNMAINTAINED: Please have a look at the vulkan-renderer
https://inexor.org
zlib License
12 stars 1 forks source link

Add spellchecker CLI for blog-data #551

Closed Croydon closed 6 years ago

Croydon commented 6 years ago

https://github.com/tbroadley/spellchecker-cli

zahiryahya1 commented 6 years ago

I would like to work on implementing this. How do you want the workflow to behave?

Croydon commented 6 years ago

The minium requirements for this would be:

Nice-to-have but not requirements for this issue:

I have enabled Travis for the repository, therefore I would recommend to

zahiryahya1 commented 6 years ago

I got the basic functionality working. What do you want me to do with the current misspelled or technical words?

Croydon commented 6 years ago

@zahiryahya1 I see that you have already created a dictionary file with a list of words. If you add "Inexor", "Sauerbraten", "CMake" and "GitHub" to it it's fine for the beginning. I will have a look at the upcoming mistakes afterwards then.

You also shouldn't let the job fail after a single file with mistakes. Please output all mistakes of all files before letting the job fail.

Good job so far!

a-teammate commented 6 years ago

I think it is alright to display them in the CI before erroring.

Then after seeing the PR's travis job failed, one would check in the log of travis why it fails, and see the errors listed together with the line and the row of the misspelled word:)

Edit: Didn't see that @Croydon already answered :) Good job btw!

Croydon commented 6 years ago

Done via https://github.com/inexorgame/blog-data/commit/5a9ff04e341623844fae4ac25f93ab7de052039c / https://github.com/inexorgame/blog-data/pull/9