search

inexorgame-obsolete / deprecated-cube-engine-inexor

UNMAINTAINED: Please have a look at the vulkan-renderer
https://inexor.org
zlib License
12 stars 1 forks source link

Hide cef_subprocess console window #566

Closed IAmNotHanni closed 6 years ago

IAmNotHanni commented 6 years ago

Multiple CEF sub processes will open a console window when Inexor has been started.

cef_subprocess

MSDN FreeConsole function
Stackoverflow

IAmNotHanni commented 6 years ago

This distracts the user. I think these windows should be hidden. The processes shouldn't terminate of course.

a-teammate commented 6 years ago

This is currently not a bug, just development state. (For logging purpose, but we can also just look in the inexorcef.log)

We can hide these windows by compiling it with a different windows subsystem. I have a untested commit which solves this, if you are willing to test it on windows @IAmNotHanni and maybe try to fix the edges which may not be working straight away, I can upload it.

IAmNotHanni commented 6 years ago

Create a pull request pls so I can review.

a-teammate commented 6 years ago

I currently don't have time for a PR (at most it can be untested).. Could you test it? and fix eventually the fuckups? It is simple: remove CONSOLE_APP in the cmakelists.txt. afterwards the main() function wont be found, since on windows it is named differently. thats why the other lines are there.

IAmNotHanni commented 6 years ago

Ok I'm on it.

IAmNotHanni commented 6 years ago

@a-teammate Why don't we just link it to another windows subsystem ?

IAmNotHanni commented 6 years ago

This pull request will fix it: https://github.com/inexorgame/inexor-core/pull/577 Awaiting confirmation/review.