inexorgame / vulkan-renderer

A new 3D game engine for Linux and Windows using C++20 and Vulkan API 1.3, in very early but ongoing development
https://inexor.org
MIT License
812 stars 34 forks source link

Use taskflow for concurrency #217

Open IAmNotHanni opened 4 years ago

IAmNotHanni commented 4 years ago

Doing multithreading correctly is a tricky business. We don't have to reinvent he wheel on that one. As we discussed earlier, we will remove our own threadpool implementation (which was very easy to deadlock) and use taskflow instead.

IAmNotHanni commented 4 years ago

There is a conan package for it: taskflow/2.5.0.

IceflowRE commented 4 years ago

The simple implementation of our own thread-pool thingy was already removed here: 62455b499385f8d182d6090ad4ef88bdb0095225

tsung-wei-huang commented 4 years ago

@IAmNotHanni I noticed this message - please don't hesitate to let me know if anything we can help you in porting taskflow (https://taskflow.github.io/) - :)

IAmNotHanni commented 4 years ago

@tsung-wei-huang Wow I just noticed your reply now! Amazing thank you!