Build type in engine metadata is empty on Windows

inexorgame / vulkan-renderer

A new 3D game engine for Linux and Windows using C++20 and Vulkan API 1.3, in very early but ongoing development

https://inexor.org

MIT License

790 stars 34 forks source link

Build type in engine metadata is empty on Windows #420

Open IAmNotHanni opened 3 years ago

IAmNotHanni commented 3 years ago

Describe the bug

Inexor Engine, version 0.1.0
Inexor Vulkan-renderer example, version 0.1.0
Configuration: , Git SHA 13e16b7
2021-07-21T20:32:20+02:00

To Reproduce Steps to reproduce the behavior: Start inexor-vulkan-renderer-benchmarks

Expected behavior The git sha is supposed to be displayed

Screenshots grafik

Desktop (please complete the following information):

OS: Windows

IAmNotHanni commented 3 years ago

Ok so I can confirm this issue does not exist on Linux.

IAmNotHanni commented 3 years ago

So the problem is that since Visual Studio is using a multiconfig, there is no defined build type while the project map is being generated in CMake. This change in meta.hpp.in will simplify and fix it:

#ifndef NDEBUG
constexpr const char *BUILD_TYPE = "Debug";
#else
constexpr const char *BUILD_TYPE = "Release";
#endif