search

inexorgame / vulkan-renderer

A new 3D game engine for Linux and Windows using C++20 and Vulkan API 1.3, in very early but ongoing development
https://inexor.org
MIT License
777 stars 34 forks source link

[ci] Fix ci #467

Closed IceflowRE closed 2 years ago

IceflowRE commented 2 years ago

CVE-2022-24765

IAmNotHanni commented 2 years ago

What about this?

Run git fetch --progress --depth=1 origin main
fatal: unsafe repository ('/__w/vulkan-renderer/vulkan-renderer' is owned by someone else)
To add an exception for this directory, call:
    git config --global --add safe.directory /__w/vulkan-renderer/vulkan-renderer
Error: Process completed with exit code 128.
IAmNotHanni commented 2 years ago

Ok I fixed the clang-tidy warning:

throw std::runtime_error("Error: No index buffer for mesh " + m_name + "!");

/__w/vulkan-renderer/vulkan-renderer/include/inexor/vulkan-renderer/wrapper/mesh_buffer.hpp:207:19: warning: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting]

I still don't understand it though, as making m_name a const reference should have resolved the warning, but it didn't (see std::runtime_error). I had to remove the m_name in the exception message entirely. This is not a problem as I will refactor the exception wrapper at some point so the name of the object associated with the exception will be passed as a separate parameter.