Refactor management of command pools, command buffers, staging buffers, and remove once command buffer

[IAmNotHanni]

Summary

Closes https://github.com/inexorgame/vulkan-renderer/issues/465 Closes https://github.com/inexorgame/vulkan-renderer/issues/459

Removed features (part of refactoring)

• [x] Remove StagingBuffer wrapper, because it is just a normal GPUMemoryBuffer, and the staging buffers for copy operations should be handled by the device wrapper internally only (note that we are not recycling staging buffers though: when they are no longer needed, the destructor of GPUMemoryBuffer is called. We should trust VMA to do the heavy work when it comes to recycling the memory for staging buffers. This is likely the best solution for now)
• [x] Remove OnceCommandBuffer wrapper, because we have the new command buffer request code using static thread_local command pools and command buffers.
• [x] Do not use multiple command pools per thread! (read https://developer.nvidia.com/blog/vulkan-dos-donts)

New features

• [x] Use static thread_local command pools and command buffers in device wrapper (Keep using CommandPool and CommandBuffer RAII wrapper)
• [x] Implement command buffer management in device wrapper (request mechanism)
• [x] Implement an execute lambda which abstracts beginning, ending and submitting command buffers, example:

m_device.execute(m_name, [&](const CommandBufferHandle &cmd_buf) {
    cmd_buf
        .change_image_layout(m_texture_image->get(), VK_IMAGE_LAYOUT_UNDEFINED,
                             VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL)
        .copy_buffer_to_image(texture_data, static_cast<VkDeviceSize>(texture_size), m_texture_image->get(),
                              copy_region, m_name)
        .change_image_layout(m_texture_image->get(), VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL,
                             VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL);
});

Use wrapper methods instead of raw Vulkan functions everywhere in the code base

• [x] Order methods in Device wrapper and CommandBuffer wrapper alphabetically in .hpp and .cpp
• [x] Improve Doxygen comments in Device wrapper and CommandBuffer wrapper

Add new wrapper methods and refactor existing ones

Device wrapper

• Update: I removed this again! Yeetari convinced me that there is really no use in this. Those methods should be used inside of the RAII wrappers. Even in those cases where they are being used outside, there is no benefit when using device wrapper methods as a replacement.

CommandBufferHandle wrapper

• [x] begin_command_buffer
• [x] begin_render_pass
• [x] bind_descriptor_sets
• [x] bind_descriptor_set
• [x] bind_pipeline
• [x] bind_index_buffer
• [x] bind_vertex_buffers
• [x] change_image_layout
• [x] copy_buffer
• [x] copy_buffer_to_image
• [x] draw
• [x] draw_indexed
• [x] end_command_buffer
• [x] end_render_pass
• [x] pipeline_barrier
• [x] push_constants
• [x] push_constant
• [x] submit_and_wait

Bugs

• [x] Fix move constructor of Device wrapper
• [x] Fix a bug that caused m_transfer_queue not to be initialized, even if the graphics queue is used as transfer queue.

Outlook

• Implement glTF Model loading and PBR rendering (https://github.com/inexorgame/vulkan-renderer/issues/256)
• Use Vulkan Memory Allocator 3 (https://github.com/inexorgame/vulkan-renderer/issues/458)
• Use timeline semaphores to synchronize command buffer requests and submission in device wrapper
• Use new debug utils (https://github.com/inexorgame/vulkan-renderer/issues/456)
• https://github.com/inexorgame/vulkan-renderer/issues/457

[IAmNotHanni]

• [x] Rebase onto main

[IAmNotHanni]

I made the pull request much smaller again, only focussing on the core refactoring. Otherwise it would have been just too much small stuff to review. I want to make a cleanup pull request after this, which can deal with the small issues step by step.

[IAmNotHanni]

Thank you for your great review @yeetari ! I'm waiting for further comments :smile:

• [x] Fix clang-tidy warning

[IceflowRE]

• [x] delete file output

[IAmNotHanni]

• [x] Follow rules for naming commits

[IAmNotHanni]

• [x] Fix a bug found by @yeetari where the device wrapper's command buffer request system would endlessly create new command buffers

[IAmNotHanni]

Thank you guys for this amazing collaboration once again!